commands: support path arguments to jj commit
#2132
Merged
+83
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arxanas
force-pushed
the
arxanas/split-3
branch
from
67be758 to
d6ebe1c
Compare
arxanas
force-pushed
the
arxanas/commit-2
branch
3 times, most recently
from
a5ed82e to
e6b833d
Compare
arxanas
force-pushed
the
arxanas/split-3
branch
2 times, most recently
from
77972af to
a4de44f
Compare
arxanas
force-pushed
the
arxanas/commit-2
branch
2 times, most recently
from
0cdb550 to
dd8467c
Compare
arxanas
force-pushed
the
arxanas/split-3
branch
from
53f2965 to
19a452c
Compare
arxanas
force-pushed
the
arxanas/commit-2
branch
from
dd8467c to
75401f7
Compare
arxanas
force-pushed
the
arxanas/split-3
branch
from
19a452c to
9ac1ff5
Compare
arxanas
force-pushed
the
arxanas/commit-2
branch
2 times, most recently
from
2fd80ab to
7efa03c
Compare
arxanas
force-pushed
the
arxanas/split-3
branch
from
9ac1ff5 to
247d097
Compare
martinvonz
reviewed
Sep 18, 2023
arxanas
force-pushed
the
arxanas/split-3
branch
from
247d097 to
837aeff
Compare
arxanas
force-pushed
the
arxanas/commit-2
branch
from
7efa03c to
0002219
Compare
arxanas
force-pushed
the
arxanas/split-3
branch
from
837aeff to
5f7d406
Compare
arxanas
force-pushed
the
arxanas/commit-2
branch
from
0002219 to
2b41274
Compare
martinvonz
approved these changes
Sep 20, 2023
martinvonz
reviewed
Sep 20, 2023
4 tasks
arxanas
force-pushed
the
arxanas/commit-2
branch
from
2b41274 to
77f61fc
Compare
arxanas
force-pushed
the
arxanas/split-2
branch
from
b1eefb3 to
04d2217
Compare
arxanas
force-pushed
the
arxanas/commit-2
branch
from
77f61fc to
184a573
Compare
martinvonz
approved these changes
Sep 25, 2023
`jj split` with no arguments operates interactively, but I am nonetheless constantly running `jj split -i` because I expect an `--interactive` flag to exist for consistency. However, `jj split <paths>` before this commit always operates non-interactively, so this commit has the nice practical effect that you can restrict your interactive splitting to a certain set of paths.
arxanas
force-pushed
the
arxanas/commit-2
branch
from
184a573 to
82880b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md